Discussion:
[PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM
Chen Gang
2014-10-04 09:48:42 UTC
Permalink
PWM_CLPS711X needs HAS_IOMEM, so depend on it, the related error (with
allmodconfig under um):

MODPOST 1205 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
ERROR: "devm_ioremap" [drivers/net/phy/mdio-bcm-unimac.ko] undefined!

Signed-off-by: Chen Gang <***@gmail.com>
---
drivers/pwm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index 3865dfb..de1ffb5 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -82,7 +82,7 @@ config PWM_BFIN

config PWM_CLPS711X
tristate "CLPS711X PWM support"
- depends on ARCH_CLPS711X || COMPILE_TEST
+ depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM
help
Generic PWM framework driver for Cirrus Logic CLPS711X.
--
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thierry Reding
2014-10-06 10:08:42 UTC
Permalink
Post by Chen Gang
PWM_CLPS711X needs HAS_IOMEM, so depend on it, the related error (with
MODPOST 1205 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
ERROR: "devm_ioremap" [drivers/net/phy/mdio-bcm-unimac.ko] undefined!
---
drivers/pwm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index 3865dfb..de1ffb5 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -82,7 +82,7 @@ config PWM_BFIN
config PWM_CLPS711X
tristate "CLPS711X PWM support"
- depends on ARCH_CLPS711X || COMPILE_TEST
+ depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM
Applied, thanks. I modified this slightly and put HAS_IOMEM on a line of
its own. This is in my opinion (slightly) more readable and matches what
we already have for other drivers.

Thierry
Chen Gang
2014-10-06 13:07:48 UTC
Permalink
Post by Thierry Reding
Post by Chen Gang
PWM_CLPS711X needs HAS_IOMEM, so depend on it, the related error (with
MODPOST 1205 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
ERROR: "devm_ioremap" [drivers/net/phy/mdio-bcm-unimac.ko] undefined!
---
drivers/pwm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index 3865dfb..de1ffb5 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -82,7 +82,7 @@ config PWM_BFIN
config PWM_CLPS711X
tristate "CLPS711X PWM support"
- depends on ARCH_CLPS711X || COMPILE_TEST
+ depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM
Applied, thanks. I modified this slightly and put HAS_IOMEM on a line of
its own. This is in my opinion (slightly) more readable and matches what
we already have for other drivers.
It is OK to me, thank you for your work.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
Loading...